Skip to content

ci(apple): fix e2e test runner suite that passes but returns as failure #17440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jul 25, 2025

Conversation

russellwheatley
Copy link
Member

@russellwheatley russellwheatley commented Jun 20, 2025

Description

For quite some time now, the macos and ios CI test runners have been exiting with exit code 1 with the following: https://github.com/firebase/flutterfire/actions/runs/16416732379/job/46384578343?pr=17541#step:16:383

Two tests were silently crashing app, one of the crashes has been fixed: https://github.com/firebase/flutterfire/pull/17440/files#diff-021dfe6df9eae0b2a7c718fd0df578115005602e6e476dece7e0b2a67139d7cbR255

The other crash is a mystery, I could not reproduce running example app with the exact same code, therefore I have opted to skip for apple platforms: https://github.com/firebase/flutterfire/pull/17440/files#diff-dd4162c32c7a0146e8a9c7874e8642422e51160833ff49eea64c852b8b215ef9R879

Related Issues

Replace this paragraph with a list of issues related to this PR from the issue database. Indicate, which of these issues are resolved or fixed by this PR. Note that you'll have to prefix the issue numbers with flutter/flutter#.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

@russellwheatley russellwheatley changed the title ci(ios): fix e2e test runner suite that passes but returns as failure ci(apple): fix e2e test runner suite that passes but returns as failure Jul 25, 2025
@russellwheatley russellwheatley marked this pull request as ready for review July 25, 2025 08:47
@russellwheatley russellwheatley merged commit 45028c9 into main Jul 25, 2025
33 of 37 checks passed
@russellwheatley russellwheatley deleted the attempt-ios-fix branch July 25, 2025 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants